Move space handling to kibanaFetch and add space support to entity-store and entity-resolution-demo commands #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
PR Overview
This PR refactors space handling by moving URL space logic into kibanaFetch and adds support for a --space parameter in multiple commands. Key changes include:
- Adding a --space option to the entity-resolution-demo and entity-store commands.
- Refactoring kibanaFetch and related URL generators to accept a space parameter and use new API version constants.
- Updating asset criticality and rule creation functions to propagate the space parameter.
Reviewed Changes
| File | Description |
|---|---|
| src/index.ts | Adds the --space option to entity-resolution-demo and entity-store commands |
| src/utils/kibana_api.ts | Refactors URL building with buildKibanaUrl and improves API version handling |
| src/constants.ts | Introduces API_VERSIONS and updates URL generators for rules and packages |
| src/utils/initialize_space.ts | Renames getSpace to doesSpaceExist for clarity in space checks |
| src/commands/entity-store.ts | Propagates the space parameter, including initializing space if non-default |
| src/commands/entity_resolution.ts | Updates package installation and rule creation to include the space parameter |
| src/commands/asset_criticality.ts | Includes the space parameter when generating asset criticality |
| src/commands/documents.ts | Removes outdated commented code |
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
src/commands/entity_resolution.ts:482
- There is a typo in the comment: 'inttegrations' should be 'integrations'.
// which the inttegrations don't provide
src/utils/kibana_api.ts:188
- [nitpick] For consistency with other URL constructions using buildKibanaUrl, consider refactoring getRule (and similarly deleteRule) to build the URL using buildKibanaUrl with query parameter handling rather than concatenating strings directly.
const url = DETECTION_ENGINE_RULES_URL + '?rule_id=' + ruleId;
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
--spaceparameter to theentity-storeandentity-resolution-democommands.Some of our URLs had a URL constant which took a space a parameter, some didn't. As every Kibana URL supports spaces I thought it better to have
kibanaFetchhandle spaces.